Site Tools


Hotfix release available: 2024-02-06a "Kaos". upgrade now! [55.1] (what's this?)
New release available: 2024-02-06 "Kaos". upgrade now! [55] (what's this?)
Hotfix release available: 2023-04-04a "Jack Jackrum". upgrade now! [54.1] (what's this?)
New release available: 2023-04-04 "Jack Jackrum". upgrade now! [54] (what's this?)
Hotfix release available: 2022-07-31b "Igor". upgrade now! [53.1] (what's this?)
Hotfix release available: 2022-07-31a "Igor". upgrade now! [53] (what's this?)
New release available: 2022-07-31 "Igor". upgrade now! [52.2] (what's this?)
New release candidate 2 available: rc2022-06-26 "Igor". upgrade now! [52.1] (what's this?)
New release candidate available: 2022-06-26 "Igor". upgrade now! [52] (what's this?)
Hotfix release available: 2020-07-29a "Hogfather". upgrade now! [51.4] (what's this?)
internal:dev_w:code_review

General

  1. Check whether the code met the functionality which specified in the spec/design document
  2. Check if the errors are handled properly
  3. Check the user interaction (Labels and Messages)
  4. Check the unit test case whether it pass or fail
  5. Check if tested in all supported browsers
  6. Check the alignment and object positioning

Java script code

  1. Check if the comments are added properly
  2. Check the code fit in our architecture framework
  3. Verify the variables,functions,methoed are handled properly
  4. Verify all the variables are defined and initialized before it used
  5. Verity widget level variables are reinitialized/unseted properly when invoking the widget more then once
  6. Check if any unnecessary conditional or looping statements are there
  7. Check if any inline style is specified
  8. Check language translation is handled or not
  9. Check the code indentation and alignments

PHP code

  1. Check if the comments are added properly
  2. Check the code fit in our architecture
  3. Check if the debug statement is included wherever it required
  4. Verify try…catch… is handled
  5. Check any SQL query is palced inside the DAO layer
  6. Check all the query statements are captured in debug file
  7. Verify all the input parameters of the procedures are checked with null or undefiend before passing
  8. Check the database connection is closed properly
  9. Check the transaction orientad operations are handled with begin transaction,commit transaction and rollback

Database

  1. Check if the comments are added properly
  2. Verify the delimiters
  3. Check the definer and db names are removed
internal/dev_w/code_review.txt · Last modified: 2023/10/21 14:35 by 47.128.25.218